Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trying to access README according to LANG #29

Draft
wants to merge 2 commits into
base: dev-branch
Choose a base branch
from

Conversation

ono-taka179
Copy link
Contributor

This is one of the proposed implementations for handling access to the translated README.
It is assumed that the file is located on the server under the name README-{LANG}.pdf (e.g. README-ja_JP.pdf).

@pep8speaks
Copy link

Hello @ono-taka179! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 381:80: E501 line too long (80 > 79 characters)
Line 389:9: E722 do not use bare 'except'
Line 391:80: E501 line too long (91 > 79 characters)

@ono-taka179
Copy link
Contributor Author

Attempts to access the translated README and opens the original README if an exception occurs.
To avoid 403 access to the server, a custom User-Agent is specified in the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants