Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle timeout due to pool exhaustion #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sbfaulkner
Copy link

@sbfaulkner sbfaulkner commented Apr 9, 2021

if the pool has no more available connections, it raises a timeout exception (ConnectionPool::TimeoutError which is a subclass of Timeout::Error)

however the ensure currently catches it and masks that exception with a ConnectionPool::Error: no connections are checked out

as far as I can tell, scoping the exception handling block a little tighter has no other impact than letting this exception through, so the consumer can actually detect the issue

any feedback/suggestions/alternatives welcome

cc @drbrain @tenderlove

@sbfaulkner sbfaulkner changed the title Handle timeout due to pool starvation Handle timeout due to pool exhaustion Apr 9, 2021
@sbfaulkner sbfaulkner force-pushed the handle-timeout-due-to-starvation branch from 25c2dd9 to c3eb6e4 Compare November 9, 2023 14:43
@sbfaulkner
Copy link
Author

rebased and re-bumped version

@rud
Copy link

rud commented Nov 9, 2023

I still find this a good set of changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants