Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change --gh-pages-docs default #128

Closed
asmeurer opened this issue Oct 19, 2016 · 5 comments
Closed

Change --gh-pages-docs default #128

asmeurer opened this issue Oct 19, 2016 · 5 comments

Comments

@asmeurer
Copy link
Member

It's a backwards incompatible change, but --gh-pages-docs defaulting to docs is not great. . is probably what people expect. Maybe we should make it a required argument.

CC @ocefpaf
@gforsyth
Copy link
Member

I think it's reasonable to change it to .

@gforsyth
Copy link
Member

We could make it a required argument and make the helper text to be pasted into the .travis.yml --gh-pages-docs . as the default?

@ocefpaf
Copy link
Contributor

ocefpaf commented Oct 20, 2016

I do not know the reasons to deploy to docs, and I am fine with #128 (comment) solution, but maybe the project is still young and a backwards incompatible change is not that bad...

@asmeurer
Copy link
Member Author

If it's required it really ought to be the argument to doctr deploy, like doctr deploy ..

gforsyth added a commit that referenced this issue Feb 7, 2017
@gforsyth
make deploy directory required argument
4a82e33 
as per discussion in #128, changing the deploy directory to a required
argument. the new usage for doctr on the travis side of things would
been
```
doctr deploy .
```

to deploy to the root directory on the ``gh-pages`` branch.
@gforsyth gforsyth mentioned this issue Feb 7, 2017
Merged
@gforsyth
Copy link
Member

gforsyth commented May 9, 2017

Done in #157.

@gforsyth gforsyth closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asmeurer @ocefpaf @gforsyth