Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(Scorecard & Metric): Better default metric behaviour, improved printing and more predefined Metrics. #11

Merged
merged 11 commits into from
Dec 20, 2022

Conversation

szemyd
Copy link
Contributor

@szemyd szemyd commented Dec 19, 2022

No description provided.

name="A new, own Metric",
category=MetricCategories.residual,
result=calculated_metric_example * 3.0,
hyperparameters={"hyper_1": 5.0},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way, we should consider using the word 'parameters'. these are parameters to a function, hyperparameters are exclusively used in the context of deep learning (which is not very popular in TS, for a reason) where the term "parameters" are already in use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I can change it.

Copy link
Contributor

@almostintuitive almostintuitive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾 looks great! I think this works, and I don't have any alternative!

@szemyd szemyd merged commit 493b4c8 into main Dec 20, 2022
@szemyd szemyd deleted the feat/scorecard branch December 20, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants