fix(ui): ensure container DOM is removed when destroying Vue 3 compon…

…ents (#2892)
dream-num · Jul 30, 2024 · 5c38528 · 5c38528
1 parent 935bdba
commit 5c38528
Show file tree

Hide file tree

Showing 61 changed files with 1,282 additions and 1,271 deletions.
diff --git a/README-ja.md b/README-ja.md
@@ -84,6 +84,7 @@ Univer はスプレッドシート、ドキュメント、プレゼンテーシ
 ### 📝 Univer Doc（開発中）
 
 - **コア機能**：段落、見出し、リスト、上付き文字、下付き文字など、ドキュメントの基本機能をサポートしています。
+- **浮動画像**：ドキュメントに画像を挿入し、テキストと画像を組み合わせて配置することができます。
 - **ヘッダー＆フッター**：ドキュメントにヘッダーとフッターを追加することができます。
 - **コメント**：追加情報を提供するために、ドキュメントにコメントを追加することができます。
 - **共同編集**[^1]：複数のユーザーが同時にドキュメントを編集することをサポートします。

diff --git a/README-zh.md b/README-zh.md
@@ -82,6 +82,7 @@ Univer 提供了丰富的电子表格、文档和幻灯片功能。以下是一
 ### 📝 Univer Doc（积极开发中）
 
 - **核心功能**：Univer 支持文档的核心功能，包括段落、标题、列表、上标、下标等。
+- **浮动图片**：允许将图片插入到文档中，并支持图文混合排版。
 - **页眉 & 页脚**：允许向文档添加页眉和页脚。
 - **评论**：允许向文档添加评论以提供额外信息。
 - **协同编辑**[^1]：支持多个用户同时编辑文档。

diff --git a/README.md b/README.md
@@ -82,6 +82,7 @@ Univer provides a wide range of features for spreadsheets, documents and present
 ### 📝 Univer Doc (Under Development)
 
 - **Core Features**: Univer supports core document features, including paragraphs, headings, lists, superscript, subscript, and more.
+- **Floating Images**: Allows inserting images into a document and supporting text and image layout.
 - **Headers & Footers**: Allows adding headers and footers to a document.
 - **Comments**: Enables adding comments to a document to provide additional information.
 - **Collaborative Editing**[^1]: Supports multiple users editing a document simultaneously.

diff --git a/common/shared/eslint/index.js b/common/shared/eslint/index.js
@@ -92,6 +92,7 @@ exports.baseRules = {
     'style/multiline-ternary': 'warn',
     'unicorn/prefer-type-error': 'warn',
     'accessor-pairs': 'warn',
+    'react/no-create-ref': 'warn',
 };
 
 exports.typescriptPreset = function typescriptPreset() {

diff --git a/common/shared/package.json b/common/shared/package.json
@@ -17,13 +17,13 @@
         "./vite": "./vite/index.js"
     },
     "dependencies": {
-        "@typescript-eslint/parser": "^7.16.1",
+        "@typescript-eslint/parser": "^7.18.0",
         "@vitejs/plugin-react": "^4.3.1",
-        "@vitest/coverage-istanbul": "^2.0.3",
+        "@vitest/coverage-istanbul": "^2.0.4",
         "happy-dom": "13.3.8",
         "javascript-obfuscator": "^4.1.1",
-        "vite": "^5.3.4",
+        "vite": "^5.3.5",
         "vite-plugin-dts": "^3.9.1",
-        "vitest": "^2.0.3"
+        "vitest": "^2.0.4"
     }
 }
diff --git a/common/storybook/package.json b/common/storybook/package.json
@@ -36,7 +36,7 @@
         "storybook-addon-swc": "^1.2.0",
         "style-loader": "^3.3.4",
         "tsconfig-paths-webpack-plugin": "^4.1.0",
-        "typescript": "^5.5.3"
+        "typescript": "^5.5.4"
     },
     "devDependencies": {
         "@univerjs/shared": "workspace:*"

diff --git a/examples/package.json b/examples/package.json
@@ -30,7 +30,7 @@
         "@univerjs/engine-render": "workspace:*",
         "@univerjs/facade": "workspace:*",
         "@univerjs/find-replace": "workspace:*",
-        "@univerjs/icons": "^0.1.65",
+        "@univerjs/icons": "^0.1.70",
         "@univerjs/rpc": "workspace:*",
         "@univerjs/sheets": "workspace:*",
         "@univerjs/sheets-conditional-formatting": "workspace:*",
@@ -77,6 +77,6 @@
         "esbuild-style-plugin": "^1.6.3",
         "less": "^4.2.0",
         "minimist": "^1.2.8",
-        "typescript": "^5.5.3"
+        "typescript": "^5.5.4"
     }
 }
diff --git a/package.json b/package.json
@@ -49,12 +49,12 @@
         "@antfu/eslint-config": "2.21.3",
         "@commitlint/cli": "^19.3.0",
         "@commitlint/config-conventional": "^19.2.2",
-        "@eslint-react/eslint-plugin": "^1.5.26",
-        "@playwright/test": "^1.45.1",
+        "@eslint-react/eslint-plugin": "^1.7.0",
+        "@playwright/test": "^1.45.3",
         "@release-it-plugins/workspaces": "^4.2.0",
         "@release-it/conventional-changelog": "^8.0.1",
         "@storybook/react": "8.1.11",
-        "@types/node": "^20.14.10",
+        "@types/node": "^22.0.0",
         "@types/react": "^18.3.3",
         "@univerjs/design": "workspace:*",
         "@univerjs/shared": "workspace:*",
@@ -64,18 +64,17 @@
         "eslint-plugin-header": "^3.1.1",
         "eslint-plugin-no-barrel-import": "^0.0.2",
         "eslint-plugin-no-penetrating-import": "^0.0.1",
-        "eslint-plugin-react": "^7.34.4",
+        "eslint-plugin-react": "^7.35.0",
         "eslint-plugin-react-hooks": "^4.6.2",
-        "eslint-plugin-react-refresh": "^0.4.8",
-        "husky": "^9.0.11",
+        "eslint-plugin-react-refresh": "^0.4.9",
+        "husky": "^9.1.4",
         "lint-staged": "^15.2.7",
         "react": "18.3.1",
         "react-dom": "18.3.1",
         "release-it": "^17.6.0",
         "serve": "^14.2.3",
-        "turbo": "^2.0.6",
-        "typescript": "^5.5.3",
-        "vitest": "^2.0.3"
+        "turbo": "^2.0.9",
+        "typescript": "^5.5.4"
     },
     "lint-staged": {
         "*": "eslint --fix"

diff --git a/packages-experimental/uni-formula-ui/package.json b/packages-experimental/uni-formula-ui/package.json
@@ -65,9 +65,9 @@
         "@univerjs/shared": "workspace:*",
         "@univerjs/uni-formula": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages-experimental/uni-formula/package.json b/packages-experimental/uni-formula/package.json
@@ -66,7 +66,7 @@
         "@univerjs/sheets-formula": "workspace:*"
     },
     "dependencies": {
-        "@univerjs/icons": "^0.1.65"
+        "@univerjs/icons": "^0.1.70"
     },
     "devDependencies": {
         "@univerjs/core": "workspace:*",
@@ -79,9 +79,9 @@
         "@univerjs/ui": "workspace:*",
         "clsx": "^2.1.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages-experimental/uniui/package.json b/packages-experimental/uniui/package.json
@@ -70,7 +70,7 @@
         "rxjs": ">=7.0.0"
     },
     "dependencies": {
-        "@univerjs/icons": "^0.1.65",
+        "@univerjs/icons": "^0.1.70",
         "rc-util": "^5.43.0"
     },
     "devDependencies": {
@@ -86,9 +86,9 @@
         "react": "18.3.1",
         "react-dom": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -74,9 +74,9 @@
         "@types/numeral": "^2.0.5",
         "@univerjs/shared": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/data-validation/package.json b/packages/data-validation/package.json
@@ -75,9 +75,9 @@
         "@univerjs/shared": "workspace:*",
         "@univerjs/sheets": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/debugger/package.json b/packages/debugger/package.json
@@ -77,9 +77,9 @@
         "@univerjs/ui": "workspace:*",
         "@vitejs/plugin-vue": "^5.0.4",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3",
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4",
         "vue": "^3.4.27"
     },
     "univerSpace": {

diff --git a/packages/design/package.json b/packages/design/package.json
@@ -74,7 +74,7 @@
         "@rc-component/color-picker": "^1.7.1",
         "@rc-component/trigger": "^2.2.0",
         "@types/react-mentions": "^4.1.13",
-        "@univerjs/icons": "^0.1.65",
+        "@univerjs/icons": "^0.1.70",
         "rc-dialog": "^9.5.2",
         "rc-dropdown": "^4.2.0",
         "rc-input": "^1.6.2",
@@ -99,13 +99,13 @@
         "@types/react-transition-group": "^4.4.10",
         "@univerjs/shared": "workspace:*",
         "clsx": "^2.1.1",
-        "dayjs": "^1.11.11",
+        "dayjs": "^1.11.12",
         "less": "^4.2.0",
         "react": "18.3.1",
         "react-dom": "18.3.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-drawing-ui/package.json b/packages/docs-drawing-ui/package.json
@@ -77,7 +77,7 @@
         "rxjs": ">=7.0.0"
     },
     "dependencies": {
-        "@univerjs/icons": "^0.1.65"
+        "@univerjs/icons": "^0.1.70"
     },
     "devDependencies": {
         "@univerjs/core": "workspace:*",
@@ -95,9 +95,9 @@
         "ot-json1": "^1.0.2",
         "react": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-drawing/package.json b/packages/docs-drawing/package.json
@@ -68,9 +68,9 @@
         "@univerjs/drawing": "workspace:*",
         "@univerjs/engine-render": "workspace:*",
         "@univerjs/shared": "workspace:*",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-hyper-link-ui/package.json b/packages/docs-hyper-link-ui/package.json
@@ -71,7 +71,7 @@
         "rxjs": ">=7.0.0"
     },
     "dependencies": {
-        "@univerjs/icons": "^0.1.65"
+        "@univerjs/icons": "^0.1.70"
     },
     "devDependencies": {
         "@univerjs/core": "workspace:*",
@@ -84,9 +84,9 @@
         "clsx": "^2.1.1",
         "react": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-hyper-link/package.json b/packages/docs-hyper-link/package.json
@@ -66,9 +66,9 @@
         "@univerjs/docs": "workspace:*",
         "@univerjs/shared": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-mention-ui/package.json b/packages/docs-mention-ui/package.json
@@ -87,9 +87,9 @@
         "less": "^4.2.0",
         "react": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-mention/package.json b/packages/docs-mention/package.json
@@ -74,9 +74,9 @@
         "@univerjs/engine-render": "workspace:*",
         "@univerjs/shared": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-thread-comment-ui/package.json b/packages/docs-thread-comment-ui/package.json
@@ -68,7 +68,7 @@
         "rxjs": ">=7.0.0"
     },
     "dependencies": {
-        "@univerjs/icons": "^0.1.65"
+        "@univerjs/icons": "^0.1.70"
     },
     "devDependencies": {
         "@univerjs/core": "workspace:*",
@@ -81,9 +81,9 @@
         "clsx": "^2.1.1",
         "react": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs-ui/package.json b/packages/docs-ui/package.json
@@ -86,9 +86,9 @@
         "less": "^4.2.0",
         "react": "18.3.1",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {

diff --git a/packages/docs/package.json b/packages/docs/package.json
@@ -69,9 +69,9 @@
         "@univerjs/engine-render": "workspace:*",
         "@univerjs/shared": "workspace:*",
         "rxjs": "^7.8.1",
-        "typescript": "^5.5.3",
-        "vite": "^5.3.4",
-        "vitest": "^2.0.3"
+        "typescript": "^5.5.4",
+        "vite": "^5.3.5",
+        "vitest": "^2.0.4"
     },
     "univerSpace": {
         ".": {