Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): support sse in network fetch #2482

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 12, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 26 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (74d185a) to head (138eb3d).

Files Patch % Lines
packages/network/src/services/http/http.service.ts 28.57% 10 Missing ⚠️
packages/network/src/services/http/response.ts 30.76% 9 Missing ⚠️
...network/src/services/http/implementations/fetch.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2482   +/-   ##
=======================================
  Coverage   27.10%   27.11%           
=======================================
  Files        1653     1653           
  Lines       83306    83315    +9     
  Branches    17256    17258    +2     
=======================================
+ Hits        22584    22588    +4     
- Misses      60722    60727    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the feat/network-progress branch from 9ba3189 to 7a2e858 Compare June 12, 2024 05:59
Copy link

github-actions bot commented Jun 12, 2024

View Deployment

#9477737539

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@wzhudev wzhudev merged commit 8f5d0f4 into dev Jun 12, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/network-progress branch June 12, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants