Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numfmt): numfmt not render after auto fill #2617

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close 2005

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.93%. Comparing base (3583fe5) to head (019a1f8).
Report is 5 commits behind head on dev.

Files Patch % Lines
.../src/controllers/numfmt.cell-content.controller.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2617      +/-   ##
==========================================
- Coverage   26.93%   26.93%   -0.01%     
==========================================
  Files        1691     1691              
  Lines       85239    85234       -5     
  Branches    17729    17726       -3     
==========================================
- Hits        22960    22956       -4     
+ Misses      62279    62278       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 26, 2024
@wzhudev wzhudev merged commit 111bc9f into dev Jun 26, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-numfmt-0625 branch June 26, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The number format is wrong after drop-down filling
4 participants