Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numfmt): numfmt not render after auto fill #2617

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(numfmt): numfmt not render after auto fill #2617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/sheets-numfmt/src/controllers/numfmt.cell-content.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@
* limitations under the License.
*/

import type { ICellData, ICellDataForSheetInterceptor,
Workbook } from '@univerjs/core';
import type {
ICellData,
ICellDataForSheetInterceptor,
Workbook,
} from '@univerjs/core';
import {
CellValueType,
Disposable,
Expand All @@ -29,8 +32,8 @@ import {
ThemeService,
UniverInstanceType,
} from '@univerjs/core';
import type { ISetNumfmtMutationParams } from '@univerjs/sheets';
import { INTERCEPTOR_POINT, INumfmtService, SetNumfmtMutation, SheetInterceptorService } from '@univerjs/sheets';
import type { ISetNumfmtMutationParams, ISetRangeValuesMutationParams } from '@univerjs/sheets';
import { INTERCEPTOR_POINT, INumfmtService, SetNumfmtMutation, SetRangeValuesMutation, SheetInterceptorService } from '@univerjs/sheets';
import { Inject } from '@wendellhu/redi';

import { of, skip, switchMap } from 'rxjs';
Expand Down Expand Up @@ -112,6 +115,11 @@ export class SheetsNumfmtCellContentController extends Disposable {
});
});
});
} else if (commandInfo.id === SetRangeValuesMutation.id) {
const params = commandInfo.params as ISetRangeValuesMutationParams;
new ObjectMatrix(params.cellValue).forValue((row, col) => {
renderCache.realDeleteValue(row, col);
});
}
}));

Expand Down
Loading