Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add commands to the right-click menu of the worksheet in the sheets-ui plugin. #2653

Closed
2 tasks done
FrontToEnd opened this issue Jul 2, 2024 · 1 comment · Fixed by #2654
Closed
2 tasks done
Assignees
Labels
bug Something isn't working scope:sheet ui

Comments

@FrontToEnd
Copy link

Initial checklist

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Problem

I want to disable the pop-up of the right-click menu, currently the onBeforeCommandExecute cannot prevent the pop-up of the right-click menu.
image

Solution

I can specify the right-click menu commands in onBeforeCommandExecute and prevent the menu from popping up by throwing an error.

@FrontToEnd FrontToEnd added the feature request New feature or request label Jul 2, 2024
@jikkai jikkai added bug Something isn't working scope:sheet ui and removed feature request New feature or request labels Jul 2, 2024
@jikkai jikkai self-assigned this Jul 2, 2024
@jikkai
Copy link
Member

jikkai commented Jul 2, 2024

I think it is a bug 🐞.
When contextMenu is set to false, the context menu of the sheet bar should not be opened. Don't worry about it, I will fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:sheet ui
Projects
None yet
2 participants