Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): ensure context menu does not open on sheets tab when contextMenu is set to false #2654

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Jul 2, 2024

close #2653

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai requested review from wzhudev and Jocs as code owners July 2, 2024 03:45
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Jul 2, 2024
@jikkai jikkai force-pushed the fix/disable-contextmenu branch from 2cdb9bd to 8d3fb98 Compare July 2, 2024 07:56
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 26.92%. Comparing base (e5020d7) to head (fe23450).
Report is 1 commits behind head on dev.

Files Patch % Lines
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 6 Missing ⚠️
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 2 Missing ⚠️
packages/ui/src/controllers/ui/ui.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2654      +/-   ##
==========================================
- Coverage   27.36%   26.92%   -0.44%     
==========================================
  Files        1709     1714       +5     
  Lines       86068    87507    +1439     
  Branches    17986    18330     +344     
==========================================
+ Hits        23551    23564      +13     
- Misses      62517    63943    +1426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the fix/disable-contextmenu branch from 8d3fb98 to fe23450 Compare July 3, 2024 02:42
@jikkai jikkai merged commit a5ecccc into dev Jul 3, 2024
9 checks passed
@jikkai jikkai deleted the fix/disable-contextmenu branch July 3, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add commands to the right-click menu of the worksheet in the sheets-ui plugin.
2 participants