Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): paste and selection error #2843

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jul 23, 2024

close #1708

fix: 首次进入单元格,粘贴会打开编辑器
https://github.com/dream-num/univer-pro/issues/1703

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 23, 2024
@univer-bot
Copy link

univer-bot bot commented Jul 23, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: fix(editor): paste and selection error

Title: fix(editor): paste and selection error


close #1708

fix: 首次进入单元格,粘贴会打开编辑器
https://github.com/dream-num/univer-pro/issues/1703

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 26.98%. Comparing base (f66e5a7) to head (9a1c923).
Report is 3 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/layout/layout.service.ts 0.00% 5 Missing ⚠️
...llers/render-controllers/zoom.render-controller.ts 0.00% 1 Missing ⚠️
...rc/controllers/sheets-thread-comment.controller.ts 0.00% 1 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 1 Missing ⚠️
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2843      +/-   ##
==========================================
+ Coverage   26.71%   26.98%   +0.27%     
==========================================
  Files        1774     1784      +10     
  Lines       93682    94205     +523     
  Branches    19934    20129     +195     
==========================================
+ Hits        25025    25421     +396     
- Misses      68657    68784     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7
Copy link

zhaolixin7 commented Jul 23, 2024

@DR-Univer 问题1、创建条件格式后直接编辑单元格,表现:fx显示编辑内容,单元格空白不显示内容
问题2、条件格式编辑面板中选中应用范围后切换子表 ,表现:选区高亮未消失
2024_7_23 20_05_40 video.webm

@univer-bot
Copy link

univer-bot bot commented Jul 23, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@DR-Univer Question 1. Edit the cell directly after creating the conditional format. Performance: fx displays the edited content, but the blank cell does not display the content.
Question 2. After selecting the application range in the conditional formatting editing panel and switching subtables, the performance: the selection highlight does not disappear.
2024_7_23 20_05_40 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 23, 2024
@DR-Univer
Copy link
Collaborator Author

DR-Univer commented Jul 24, 2024

@DR-Univer 问题1、创建条件格式后直接编辑单元格,表现:fx显示编辑内容,单元格空白不显示内容 问题2、条件格式编辑面板中选中应用范围后切换子表 ,表现:选区高亮未消失 2024_7_23 20_05_40 video.webm

问题2需要等 @Gggpound 的一个pr后合入才好解决 #2828
问题1搞定了

@univer-bot
Copy link

univer-bot bot commented Jul 24, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@DR-Univer Question 1. Edit the cell directly after creating the conditional format. Performance: fx displays the edited content, but the blank cell does not display the content. Question 2. Select the application range in the conditional format editing panel and switch the subtable. Performance: The selection is high The light has not disappeared 2024_7_23 20_05_40 video.webm

Problem 2 needs to wait for a PR from @Gggpound before merging it. #2828
Problem 1 solved

@DR-Univer DR-Univer added qa:untested This PR is ready to be tested and removed qa:rejected labels Jul 24, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 24, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 24, 2024
@DR-Univer DR-Univer merged commit e6869e4 into dev Jul 24, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-editor-copy-selection-error branch July 24, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants