Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): close panel when switch subunit #2828

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Jul 20, 2024

close https://github.com/dream-num/univer-pro/issues/1708

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 26.98%. Comparing base (e6869e4) to head (4ba890a).

Files Patch % Lines
...atting-ui/src/components/panel/rule-edit/index.tsx 0.00% 7 Missing ⚠️
...atting-ui/src/components/panel/rule-list/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2828   +/-   ##
=======================================
  Coverage   26.98%   26.98%           
=======================================
  Files        1784     1784           
  Lines       94229    94228    -1     
  Branches    20135    20134    -1     
=======================================
  Hits        25432    25432           
+ Misses      68797    68796    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 20, 2024

View Deployment

#10089583848

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 22, 2024
@univer-bot
Copy link

univer-bot bot commented Jul 23, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After observation, it was found that the problem occurred when the data verification ptompt panel was operated for the first time. Closing the panel for the second time closes the selection.

@Gggpound Gggpound added the qa:untested This PR is ready to be tested label Jul 24, 2024
@univer-bot univer-bot bot removed the qa:rejected label Jul 24, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jul 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jul 25, 2024
@Gggpound Gggpound merged commit 6e772bc into dev Jul 25, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-range-panel-0720 branch July 25, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants