Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): set selection should ensure the selection is not null #3497

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

VicKun4937
Copy link
Contributor

@VicKun4937 VicKun4937 commented Sep 20, 2024

  • Fix the issue where cell selection is lost after unmerging cells.

Copy link

github-actions bot commented Sep 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 20, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  bc124bb
info  For more information, see full report

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.93%. Comparing base (86c2dd9) to head (bc124bb).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3497   +/-   ##
=======================================
  Coverage   30.93%   30.93%           
=======================================
  Files        2159     2159           
  Lines      113354   113354           
  Branches    24863    24863           
=======================================
  Hits        35065    35065           
  Misses      78289    78289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937 VicKun4937 merged commit 7b89f27 into dev Sep 20, 2024
9 checks passed
@VicKun4937 VicKun4937 deleted the fix-sheet-selection branch September 20, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants