Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): set selection should ensure the selection is not null #3497

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(sheet): set selection should ensure the selection is not null #3497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13c6c7d
fix(sheet): set selection should ensure the selection is not null
VicKun4937 Sep 20, 2024
bc124bb
fix(sheet): use ?? instead
VicKun4937 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sheets/src/services/selections/selection-manager.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class SheetsSelectionsService extends RxDisposable {
}

const { unitId, sheetId } = current;
this._ensureWorkbookSelection(unitId).setSelections(sheetId, unitIdOrSelections, worksheetIdOrType as SelectionMoveType ?? SelectionMoveType.MOVE_END);
this._ensureWorkbookSelection(unitId).setSelections(sheetId, unitIdOrSelections ?? selectionDatas, worksheetIdOrType as SelectionMoveType ?? SelectionMoveType.MOVE_END);
}

clearCurrentSelections(): void {
Expand Down
Loading