Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): header footer render after switch from modern mode to traditional model #3995

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 7, 2024

close https://github.com/dream-num/univer-pro/issues/2966

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Jocs Jocs marked this pull request as ready for review November 7, 2024 10:11
@Jocs Jocs requested a review from jikkai as a code owner November 7, 2024 10:11
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 7, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 43 seconds
commit  af65764
info  For more information, see full report

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.70%. Comparing base (fe60a29) to head (af65764).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ui/src/controllers/doc-header-footer.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3995   +/-   ##
=======================================
  Coverage   32.70%   32.70%           
=======================================
  Files        2439     2439           
  Lines      126559   126557    -2     
  Branches    28352    28352           
=======================================
  Hits        41396    41396           
+ Misses      85163    85161    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Nov 8, 2024
@Jocs Jocs merged commit fd07903 into dev Nov 8, 2024
13 checks passed
@Jocs Jocs deleted the fix/header-footer-render branch November 8, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants