Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): header footer render after switch from modern mode to traditional model #3995

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,6 @@ export class DocHeaderFooterController extends Disposable implements IRenderModu
return;
}

if (!this._isTraditionalMode()) {
return;
}

if (currentRender == null) {
return;
}
Expand All @@ -322,6 +318,11 @@ export class DocHeaderFooterController extends Disposable implements IRenderModu
if (this._editorService.isEditor(unitId)) {
return;
}

if (!this._isTraditionalMode()) {
return;
}

const viewModel = this._docSkeletonManagerService.getViewModel();
const editArea = viewModel.getEditArea();
const isEditBody = editArea === DocumentEditArea.BODY;
Expand Down Expand Up @@ -426,8 +427,4 @@ export class DocHeaderFooterController extends Disposable implements IRenderModu

return documentFlavor === DocumentFlavor.TRADITIONAL;
}

private _getDocDataModel() {
return this._context.unit;
}
}
Loading