feat(design): add preservePositionOnDestroy & defaultPosition to Dialog
#1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1439 +/- ##
==========================================
- Coverage 31.51% 31.50% -0.01%
==========================================
Files 880 880
Lines 49364 49378 +14
Branches 10188 10192 +4
==========================================
Hits 15559 15559
- Misses 33805 33819 +14 ☔ View full report in Codecov by Sentry. |
jikkai
changed the title
preservePositionOnDestroy to DialogpreservePositionOnDestroy & defaultPosition to Dialog
Gggpound
pushed a commit
that referenced
this pull request
Mar 5, 2024
…Dialog (#1439) * feat(design): add `preservePositionOnDestroy` to Dialog * feat(design): add `preservePositionOnDestroy` & `defaultPosition` to Dialog * ci: fix storybook preview link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.close https://github.com/dream-num/univer-pro/issues/285
Test cases will be added once Storybook integration is complete.