Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): add doc uniscript example #1495

Merged
merged 6 commits into from
Mar 6, 2024
Merged

feat(example): add doc uniscript example #1495

merged 6 commits into from
Mar 6, 2024

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Mar 6, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

  • add doc uniscript demo
  • add doc appendText api for facade

test:

  1. open doc-uniscript demo
  2. open uniscript panel
  3. paste this code univerAPI.getActiveDocument()?.appendText('Hello, Univer!');
  4. excute script
  5. check the document content change

Copy link

github-actions bot commented Mar 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 32.68%. Comparing base (271574a) to head (e714aff).

Files Patch % Lines
packages/facade/src/apis/facade.ts 17.39% 19 Missing ⚠️
packages/facade/src/apis/docs/f-document.ts 62.06% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1495      +/-   ##
==========================================
+ Coverage   32.67%   32.68%   +0.01%     
==========================================
  Files         906      907       +1     
  Lines       50465    50514      +49     
  Branches    10520    10526       +6     
==========================================
+ Hits        16491    16513      +22     
- Misses      33974    34001      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir force-pushed the dushusir/facade-docs branch from 66e11bc to 641152b Compare March 6, 2024 12:20
@Dushusir Dushusir marked this pull request as ready for review March 6, 2024 12:22
@Dushusir Dushusir requested a review from wzhudev as a code owner March 6, 2024 12:22
@Dushusir Dushusir requested review from hexf00 and jikkai March 6, 2024 13:10
@wzhudev wzhudev merged commit ed01f92 into dev Mar 6, 2024
7 checks passed
@wzhudev wzhudev deleted the dushusir/facade-docs branch March 6, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants