Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): refactor of text shaping and support kerning #1785

Merged
merged 27 commits into from
Apr 13, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 2, 2024

close #1755

TODOs

  • Font handling and fallback mechanics
    • Font loading capability: preload and load specified fonts
    • Ability to fuzzy font matching, match the best font based on font family and style, font weight, etc
  • Text Shaping
    • Refactored text shaping to support the use of the new shaping engine with window.queryLocalFonts support and user authorization
    • The ability to font fallback
  • Under the new text shaping, a variety of styles NEED test and reimplement
    • italic、bold、underline etc
  • Test cases.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 9.17431% with 297 lines in your changes are missing coverage. Please review.

Project coverage is 29.49%. Comparing base (f80ed5d) to head (dc25600).

❗ Current head dc25600 differs from pull request most recent head 0d2b644. Consider uploading reports for the commit 0d2b644 to get more accurate results

Files Patch % Lines
...ponents/docs/layout/shaping-engine/font-library.ts 0.00% 128 Missing ⚠️
...ponents/docs/layout/shaping-engine/text-shaping.ts 0.00% 87 Missing ⚠️
.../components/docs/layout/block/paragraph/shaping.ts 0.00% 61 Missing ⚠️
...e-render/src/components/docs/layout/model/glyph.ts 0.00% 12 Missing ⚠️
...omponents/docs/layout/shaping-engine/font-cache.ts 11.11% 8 Missing ⚠️
...src/components/docs/layout/shaping-engine/utils.ts 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1785      +/-   ##
==========================================
- Coverage   29.58%   29.49%   -0.09%     
==========================================
  Files        1165     1168       +3     
  Lines       63239    63529     +290     
  Branches    13312    13380      +68     
==========================================
+ Hits        18707    18736      +29     
- Misses      44532    44793     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs force-pushed the feat/text-shaping-kerning branch from 8eeb2b6 to 6f7da81 Compare April 3, 2024 08:02
Copy link

github-actions bot commented Apr 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs force-pushed the feat/text-shaping-kerning branch 4 times, most recently from 2ee8752 to 9ece2ff Compare April 8, 2024 11:45
@Jocs Jocs requested a review from jikkai April 8, 2024 13:09
@Jocs Jocs force-pushed the feat/text-shaping-kerning branch from 7c4308e to 2e4fb5a Compare April 8, 2024 13:11
@Jocs Jocs marked this pull request as ready for review April 8, 2024 13:12
@Jocs Jocs force-pushed the feat/text-shaping-kerning branch from 2e4fb5a to 0a4ed7c Compare April 9, 2024 13:06
@Jocs Jocs requested a review from lumixraku April 10, 2024 03:38
@Jocs Jocs force-pushed the feat/text-shaping-kerning branch 3 times, most recently from 68a6c33 to bac0e1d Compare April 11, 2024 08:08
@Jocs Jocs force-pushed the feat/text-shaping-kerning branch from fc6e43a to fb6cf00 Compare April 13, 2024 05:41
@Jocs Jocs merged commit e7f1036 into dev Apr 13, 2024
8 checks passed
@Jocs Jocs deleted the feat/text-shaping-kerning branch April 13, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Ticket] Refactor of text shaping and support kerning
4 participants