Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): fix slider to stop responding to mouse movement after release during zoom operations #1834

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 9, 2024

close #1206

@jikkai jikkai requested a review from wzhudev as a code owner April 9, 2024 06:53
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.76%. Comparing base (52b2698) to head (cb1766a).

Files Patch % Lines
packages/design/src/components/slider/Slider.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1834   +/-   ##
=======================================
  Coverage   29.76%   29.76%           
=======================================
  Files        1159     1159           
  Lines       62843    62843           
  Branches    13195    13195           
=======================================
  Hits        18703    18703           
  Misses      44140    44140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 3d5a26e into dev Apr 9, 2024
8 checks passed
@jikkai jikkai deleted the fix/slider branch April 9, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug缩小、放大页面后松开鼠标仍可修改缩放
1 participant