-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheets-ui): after unhiding row or col icon doesn't disappear #2075
Conversation
View Deployment
|
同时设置多个隐藏行时,还是有问题 Univer.Sheets.-.-.Microsoft.Edge.2024-04-25.19-55-14.mp4 |
There is still a problem when setting multiple hidden rows at the same time Univer.Sheets.-.-.Microsoft.Edge.2024-04-25.19-55-14.mp4 |
@kovsu Thanks for opening this PR! Univer uses a model -> rendering approach. After some investigation, I noticed that
If you would like to make a more proper fix, we would be very happy to merge this PR. Thanks for your effort! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use another approach. Thanks!
明天修 :) |
Will fix it tomorrow :) |
@oumomomo 这样是正常的吧 2024-04-26.08.29.56.mov |
@oumomomo This is normal, right? 2024-04-26.08.29.56.mov |
close #2063
before:
2024-04-25.18.46.51.mov
after:
2024-04-25.18.45.52.mov