Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): after unhiding row or col icon doesn't disappear #2075

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Apr 25, 2024

close #2063

before:

2024-04-25.18.46.51.mov

after:

2024-04-25.18.45.52.mov

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo
Copy link

同时设置多个隐藏行时,还是有问题

Univer.Sheets.-.-.Microsoft.Edge.2024-04-25.19-55-14.mp4

@univer-bot
Copy link

univer-bot bot commented Apr 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

There is still a problem when setting multiple hidden rows at the same time

Univer.Sheets.-.-.Microsoft.Edge.2024-04-25.19-55-14.mp4

@oumomomo oumomomo added qa:rejected and removed qa:untested This PR is ready to be tested labels Apr 25, 2024
@wzhudev
Copy link
Member

wzhudev commented Apr 25, 2024

@kovsu Thanks for opening this PR!

Univer uses a model -> rendering approach. After some investigation, I noticed that _clearShapes is not invoked in _update when a related mutation is triggered:

If you would like to make a more proper fix, we would be very happy to merge this PR. Thanks for your effort! ❤️

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use another approach. Thanks!

@kovsu
Copy link
Contributor Author

kovsu commented Apr 25, 2024

Should use another approach. Thanks!

明天修 :)

@univer-bot
Copy link

univer-bot bot commented Apr 25, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Should use another approach. Thanks!

Will fix it tomorrow :)

@kovsu kovsu requested a review from wzhudev April 26, 2024 00:21
@kovsu
Copy link
Contributor Author

kovsu commented Apr 26, 2024

@oumomomo 这样是正常的吧

2024-04-26.08.29.56.mov

@univer-bot
Copy link

univer-bot bot commented Apr 26, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@oumomomo This is normal, right?

2024-04-26.08.29.56.mov

@wzhudev wzhudev added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 26, 2024
@univer-bot univer-bot bot removed the qa:rejected label Apr 26, 2024
@wzhudev wzhudev merged commit f07c2d9 into dream-num:dev Apr 26, 2024
9 checks passed
@kovsu kovsu deleted the fix-#2063 branch April 26, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] After hiding a row and then unhiding it, the icon does not disappear.
3 participants