Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InsertSheetCommand): allow using partial sheet from params as sheetconfig #2429

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

a1yamino
Copy link
Contributor

@a1yamino a1yamino commented Jun 5, 2024

…eetconfig

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.11%. Comparing base (ed39371) to head (4d1bd6e).

Current head 4d1bd6e differs from pull request most recent head 09a3f42

Please upload reports for the commit 09a3f42 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2429      +/-   ##
==========================================
+ Coverage   27.09%   27.11%   +0.01%     
==========================================
  Files        1647     1647              
  Lines       83115    83114       -1     
  Branches    17223    17224       +1     
==========================================
+ Hits        22523    22536      +13     
+ Misses      60592    60578      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jun 5, 2024

View Deployment

#9381755409

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@a1yamino a1yamino merged commit ce85854 into dev Jun 5, 2024
9 checks passed
@a1yamino a1yamino deleted the feat/insertsheet branch June 5, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants