Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conditional-formatting): distinguish between settings and purges … #2605

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(conditional-formatting): distinguish between settings and purges … #2605

merged 1 commit into from
Jun 25, 2024

Conversation

Gggpound
Copy link
Contributor

close 575

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jun 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (2d5de98) to head (575b090).
Report is 2 commits behind head on dev.

Files Patch % Lines
...ting-ui/src/controllers/cf.auto-fill.controller.ts 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #2605      +/-   ##
==========================================
- Coverage   27.12%   27.12%   -0.01%     
==========================================
  Files        1675     1675              
  Lines       84653    84658       +5     
  Branches    17642    17644       +2     
==========================================
  Hits        22961    22961              
- Misses      61692    61697       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Jun 25, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Jun 25, 2024
@Gggpound Gggpound merged commit 6dd8bbe into dev Jun 25, 2024
9 checks passed
@Gggpound Gggpound deleted the fix-cf-auto-fill-0624 branch June 25, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jocs Jocs Jocs approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gggpound @Jocs @zhaolixin7