Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permission): initial permission is modified to false for the set… #2768

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Gggpound
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.97%. Comparing base (65e471d) to head (0ee9062).

Files Patch % Lines
...ssion/range-permission/range-protection.service.ts 0.00% 1 Missing ⚠️
...rksheet-permission/worksheet-permission.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2768      +/-   ##
==========================================
- Coverage   25.97%   25.97%   -0.01%     
==========================================
  Files        1695     1695              
  Lines       90746    90748       +2     
  Branches    19140    19140              
==========================================
  Hits        23571    23571              
- Misses      67175    67177       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

View Deployment

#9919816456

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

@wzhudev
Copy link
Member

wzhudev commented Jul 15, 2024

默认是否有权限应该给一个配置吧,这样会要求大家都手动设置为 true?会变成一个 breaking change

@univer-bot
Copy link

univer-bot bot commented Jul 15, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Should there be a configuration for default permissions? This will require everyone to manually set it to true? will become a breaking change

@Gggpound Gggpound merged commit c2f3056 into dev Jul 17, 2024
9 checks passed
@Gggpound Gggpound deleted the feat-permission-0713 branch July 17, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants