Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix focus editor position with padding #2819

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Jul 19, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@hexf00 hexf00 requested a review from Jocs as a code owner July 19, 2024 07:44
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.05%. Comparing base (cede9f4) to head (eefb251).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2819   +/-   ##
=======================================
  Coverage   26.05%   26.05%           
=======================================
  Files        1741     1741           
  Lines       92525    92522    -3     
  Branches    19566    19566           
=======================================
  Hits        24106    24106           
+ Misses      68419    68416    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 19, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 57dd020 into dev Jul 19, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/fix-focus-editor-pos branch July 19, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants