fix(numfmt): numfmt skip null or undefined #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3188 +/- ##
==========================================
- Coverage 28.53% 28.53% -0.01%
==========================================
Files 2022 2022
Lines 106799 106799
Branches 23071 23071
==========================================
- Hits 30479 30473 -6
- Misses 76320 76326 +6 ☔ View full report in Codecov by Sentry. |
zhaolixin7
added
the
qa:verified
Jocs
reviewed
Aug 26, 2024
| @@ -81,7 +81,7 @@ export class SheetsNumfmtCellContentController extends Disposable { | |||
| } | |||
|
|
|||
| // just handle number | |||
| if (originCellValue.t !== CellValueType.NUMBER) { | |||
| if (originCellValue.t !== CellValueType.NUMBER || originCellValue.v === undefined || originCellValue.v === null || Number.isNaN(originCellValue.v)) { | |||
There was a problem hiding this comment.
建议使用 originCellValue.v == null
Gggpound
force-pushed
the
fix-numfmt-0824
branch
from
ccebf5d
to
d513c4f
Compare
Jocs
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2971
Pull Request Checklist