Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add clipboard hooks and selection api #3216

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Aug 27, 2024

close #xxx

clipboard

  • FUniver.copy(): Promise<boolean>
  • FUniver.paste(): Promise<boolean>
  • FHooks.onBeforeCopy(this: FHooks, callback: () => void): IDisposable
  • FHooks.onCopy(this: FHooks, callback: () => void): IDisposable
  • FHooks.onBeforePaste(this: FHooks, callback: () => void): IDisposable
  • FHooks.onPaste(this: FHooks, callback: () => void): IDisposable

docs

  • FDocument.setSelection(startOffset: number, endOffset: number): void

sheets

  • FWorkbook.setActiveRange(range: FRange): void
  • FWorkbook.getActiveRange(): FRange | null
  • FWorksheet.getActiveRange(): FRange | null
  • FWorksheet.setActiveRange(range: FRange): void
  • FWorksheet.setActiveSelection(range: FRange): void

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Aug 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 30.22%. Comparing base (04f156e) to head (1911744).
Report is 11 commits behind head on dev.

Files with missing lines Patch % Lines
packages/facade/src/apis/docs/f-document.ts 20.00% 4 Missing ⚠️
packages/facade/src/apis/sheets/f-workbook.ts 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3216      +/-   ##
==========================================
+ Coverage   30.19%   30.22%   +0.03%     
==========================================
  Files        2112     2113       +1     
  Lines      109801   109862      +61     
  Branches    23879    23889      +10     
==========================================
+ Hits        33153    33209      +56     
- Misses      76648    76653       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexf00 hexf00 changed the title feat(facade): add copy and clipboard hooks feat(facade): add clipboard hooks and selection api Sep 5, 2024
@hexf00 hexf00 marked this pull request as ready for review September 5, 2024 10:07
@hexf00 hexf00 requested a review from ybzky September 5, 2024 10:23
@hexf00 hexf00 merged commit e2fbf0e into dev Sep 6, 2024
13 checks passed
@hexf00 hexf00 deleted the feat/facade-copy branch September 6, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants