Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): refactor menu service & config service #3246

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Aug 29, 2024

Known issues:

  • The menu is broken in 'uni mode'

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@jikkai jikkai changed the title refactor(ui): refactor menu service refactor(ui): refactor menu service & config service Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 843 lines in your changes missing coverage. Please review.

Project coverage is 30.09%. Comparing base (ebde3da) to head (4d8b91f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/views/components/ribbon/Ribbon.tsx 0.00% 69 Missing ⚠️
packages/ui/src/services/menu/menu2.service.ts 0.00% 53 Missing ⚠️
packages/ui/src/services/menu/types.ts 0.00% 39 Missing ⚠️
packages/ui/src/components/menu/desktop/Menu.tsx 0.00% 29 Missing ⚠️
...c/views/components/ribbon/TooltipButtonWrapper.tsx 0.00% 23 Missing ⚠️
...rmatting-ui/src/controllers/cf.panel.controller.ts 0.00% 20 Missing ⚠️
packages/sheets-formula/src/formula-ui-plugin.ts 0.00% 19 Missing ⚠️
packages/ui/src/services/menu/menu.service.ts 0.00% 17 Missing ⚠️
...ges/ui/src/views/components/ribbon/ToolbarItem.tsx 0.00% 14 Missing ⚠️
...kages/ui/src/components/menu/mobile/MobileMenu.tsx 0.00% 11 Missing ⚠️
... and 163 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3246      +/-   ##
==========================================
- Coverage   30.18%   30.09%   -0.09%     
==========================================
  Files        2039     2109      +70     
  Lines      109347   109667     +320     
  Branches    23781    23849      +68     
==========================================
  Hits        33004    33004              
- Misses      76343    76663     +320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai force-pushed the feat/refactor-menu branch 10 times, most recently from 7e67941 to 285dd13 Compare September 3, 2024 12:57
@jikkai jikkai merged commit 3cf0509 into dev Sep 4, 2024
9 checks passed
@jikkai jikkai deleted the feat/refactor-menu branch September 4, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant