Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): refactor of doc selections #3299

Merged
merged 8 commits into from
Sep 11, 2024
Merged

refactor(docs): refactor of doc selections #3299

merged 8 commits into from
Sep 11, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Sep 3, 2024

close https://github.com/dream-num/univer-pro/issues/2407

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Breaking changes

  • The TextSelectionManagerService service was renamed to DocSelectionManagerService.
  • Some of the APIs in the docs package were moved to the docs-ui package.
  • TextSelectionRenderManagerService is migrated to the docs-ui package, renamed to DocSelectionRenderService, and the IRenderModule interface is implemented.

@Jocs Jocs force-pushed the refactor/doc-selection branch from a59e6fe to a0f3bbb Compare September 6, 2024 07:50
@Jocs Jocs marked this pull request as ready for review September 6, 2024 08:10
@Jocs Jocs force-pushed the refactor/doc-selection branch 2 times, most recently from 60ca259 to 143ad7e Compare September 6, 2024 08:24
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 8.86981% with 637 lines in your changes missing coverage. Please review.

Project coverage is 30.39%. Comparing base (83238fa) to head (a912d54).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/docs-ui/src/basics/selection.ts 22.44% 76 Missing ⚠️
...services/selection/doc-selection-render.service.ts 1.66% 59 Missing ⚠️
...heets-formula/src/controllers/prompt.controller.ts 0.00% 41 Missing ⚠️
...der-controllers/doc-selection-render.controller.ts 0.00% 31 Missing ⚠️
...docs/src/services/doc-selection-manager.service.ts 0.00% 29 Missing ⚠️
...render-controllers/doc-editor-bridge.controller.ts 0.00% 21 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 17 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 16 Missing ⚠️
...es/docs-ui/src/commands/commands/delete.command.ts 0.00% 15 Missing ⚠️
...ages/docs-ui/src/commands/commands/list.command.ts 0.00% 14 Missing ⚠️
... and 80 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3299      +/-   ##
==========================================
- Coverage   30.45%   30.39%   -0.07%     
==========================================
  Files        2126     2127       +1     
  Lines      110792   110863      +71     
  Branches    24181    24200      +19     
==========================================
- Hits        33742    33692      -50     
- Misses      77050    77171     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs force-pushed the refactor/doc-selection branch 6 times, most recently from 8b58cc8 to 8eec901 Compare September 6, 2024 11:19
Copy link

github-actions bot commented Sep 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@oumomomo oumomomo added the qa:untested This PR is ready to be tested label Sep 6, 2024
@Jocs Jocs force-pushed the refactor/doc-selection branch 5 times, most recently from 322d218 to 4f6fdc6 Compare September 10, 2024 13:07
@Jocs Jocs force-pushed the refactor/doc-selection branch from 5752887 to a912d54 Compare September 11, 2024 06:42
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 11, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 11, 2024
@Jocs Jocs merged commit 8b42b45 into dev Sep 11, 2024
9 checks passed
@Jocs Jocs deleted the refactor/doc-selection branch September 11, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants