Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permission): fix permission render bugs #3300

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 3, 2024

close #3293 https://github.com/dream-num/univer-pro/issues/1603 https://github.com/dream-num/univer-pro/issues/796 https://github.com/dream-num/univer-pro/issues/2372

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from jikkai and wzhudev as code owners September 3, 2024 10:08
@ybzky ybzky requested a review from Gggpound September 3, 2024 10:08
Copy link

github-actions bot commented Sep 3, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.

Project coverage is 30.17%. Comparing base (e0d67ec) to head (6ce1e76).
Report is 19 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/permission/sheet-permission-init.controller.ts 0.00% 28 Missing ⚠️
...s/permission/sheet-permission-render.controller.ts 0.00% 28 Missing ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 8 Missing ⚠️
...on/sheet-permission-interceptor-base.controller.ts 0.00% 6 Missing ⚠️
...permission-interceptor-canvas-render.controller.ts 0.00% 2 Missing ⚠️
...es/sheets/src/model/range-protection-rule.model.ts 0.00% 2 Missing ⚠️
...heet-permission/worksheet-permission-rule.model.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3300      +/-   ##
==========================================
+ Coverage   30.09%   30.17%   +0.07%     
==========================================
  Files        2109     2111       +2     
  Lines      109680   109806     +126     
  Branches    23849    23881      +32     
==========================================
+ Hits        33009    33132     +123     
- Misses      76671    76674       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky requested review from Jocs and DR-Univer as code owners September 3, 2024 12:02
@ybzky ybzky force-pushed the fix-permission-render-bugs branch from f0fdda3 to a931cef Compare September 4, 2024 03:57
@ybzky ybzky force-pushed the fix-permission-render-bugs branch from a931cef to 05cf765 Compare September 4, 2024 06:20
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 5, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 5, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 5, 2024
@ybzky ybzky merged commit 9751c0a into dev Sep 5, 2024
10 checks passed
@ybzky ybzky deleted the fix-permission-render-bugs branch September 5, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
3 participants