Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-thread-comment-ui): delete comment error #3476

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 18, 2024

close https://github.com/dream-num/univer-pro/issues/2437

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 18, 2024

Playwright test results

passed  4 passed

Details

stats  4 tests across 2 suites
duration  1 minute, 23 seconds
commit  bdd6917
info  For more information, see full report

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@3cf7b46). Learn more about missing BASE report.
Report is 26 commits behind head on dev.

Files with missing lines Patch % Lines
...comment-ui/src/views/thread-comment-tree/index.tsx 0.00% 5 Missing ⚠️
.../thread-comment/src/models/thread-comment.model.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #3476   +/-   ##
======================================
  Coverage       ?   30.67%           
======================================
  Files          ?     2155           
  Lines          ?   113017           
  Branches       ?    24770           
======================================
  Hits           ?    34671           
  Misses         ?    78346           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Sep 19, 2024
@weird94 weird94 merged commit 01a78da into dev Sep 20, 2024
9 checks passed
@weird94 weird94 deleted the fix/comment-delete branch September 20, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants