-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: border for merged cell #3506
Conversation
View Deployment
|
Playwright test resultsDetails 4 tests across 2 suites |
c681bc1
to
36966dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3506 +/- ##
==========================================
+ Coverage 30.90% 30.93% +0.02%
==========================================
Files 2161 2161
Lines 113511 113530 +19
Branches 24893 24888 -5
==========================================
+ Hits 35079 35116 +37
+ Misses 78432 78414 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
9eb80a2
to
4f9d9a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be unit tests for the bugfix.
@lumixraku 单元格和合并单元格组合,设置内边框边框线预期:外边框线不应该显示 |
@lumixraku Cell and merged cell combination, set inner border border line Expectation: outer border line should not be displayed |
4f9d9a8
to
c02aa09
Compare
@wzhudev see https://github.com/dream-num/univer/pull/3506/files#diff-29f4358918948f1bd6a68ec7b1514c6c8914a67ebec5c166d358549041b723bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b4d816f
to
2d801a0
Compare
2d801a0
to
ab8f523
Compare
close https://github.com/dream-num/univer-pro/issues/2561
close #3391
Pull Request Checklist