Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change controller register timing #3516

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Sep 21, 2024

close #3567

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@ybzky ybzky requested review from Gggpound and removed request for wzhudev and DR-Univer September 21, 2024 02:27
Copy link

github-actions bot commented Sep 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 21, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 4 seconds
commit  fe92036
info  For more information, see full report

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (4bc700b) to head (fe92036).
Report is 54 commits behind head on dev.

Files with missing lines Patch % Lines
...es/sheets/src/controllers/merge-cell.controller.ts 54.54% 5 Missing ⚠️
packages/sheets/src/sheets-plugin.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3516      +/-   ##
==========================================
+ Coverage   30.83%   31.84%   +1.01%     
==========================================
  Files        2158     2194      +36     
  Lines      113186   115185    +1999     
  Branches    24825    25369     +544     
==========================================
+ Hits        34897    36680    +1783     
- Misses      78289    78505     +216     
Flag Coverage Δ
31.84% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add some unit tests.

packages/sheets/src/controllers/merge-cell.controller.ts Outdated Show resolved Hide resolved
@ybzky ybzky requested a review from wzhudev September 24, 2024 12:57
@wzhudev wzhudev changed the title chore: change controller register opportunity chore: change controller register timing Sep 25, 2024
@wzhudev wzhudev merged commit 95935e2 into dev Sep 25, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-node-controller-register branch September 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants