Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): data bar render error #3535

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Sep 23, 2024

close https://github.com/dream-num/univer-pro/issues/2564
close #3566

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 23, 2024
Copy link

Playwright test results

passed  3 passed
flaky  1 flaky

Details

stats  4 tests across 2 suites
duration  1 minute, 52 seconds
commit  caaaa03
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@VicKun4937
Copy link
Contributor

@lumixraku please have a look, it my fault use a mistake function

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.90%. Comparing base (99dd398) to head (caaaa03).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...nditional-formatting/src/render/data-bar.render.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3535   +/-   ##
=======================================
  Coverage   30.90%   30.90%           
=======================================
  Files        2161     2161           
  Lines      113511   113511           
  Branches    24893    24893           
=======================================
  Hits        35079    35079           
  Misses      78432    78432           
Flag Coverage Δ
30.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 23, 2024
@Gggpound Gggpound merged commit f11c87f into dev Sep 23, 2024
10 checks passed
@Gggpound Gggpound deleted the fix-cf-data-bar-0923 branch September 23, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] conditional formtting dataBar position has offset
4 participants