Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar offset when moving by mouse #3556

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: scrollbar offset when moving by mouse #3556

merged 1 commit into from
Sep 25, 2024

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Sep 24, 2024

close #3554

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@lumixraku lumixraku self-assigned this Sep 24, 2024
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 24, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 3 seconds
commit  cb13d59
info  For more information, see full report

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.94%. Comparing base (6338846) to head (cb13d59).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/shape/scroll-bar.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3556   +/-   ##
=======================================
  Coverage   30.94%   30.94%           
=======================================
  Files        2161     2161           
  Lines      113569   113569           
  Branches    24894    24894           
=======================================
+ Hits        35146    35148    +2     
+ Misses      78423    78421    -2     
Flag Coverage Δ
30.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 24, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 25, 2024
@univer-bot univer-bot bot removed the qa:rejected label Sep 25, 2024
@lumixraku lumixraku requested a review from jikkai September 25, 2024 03:06
@jikkai jikkai merged commit 5ebbc02 into dev Sep 25, 2024
9 checks passed
@jikkai jikkai deleted the fix/scrollbar-pos branch September 25, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Scrollbar Jumps on Drag Start
3 participants