Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-data-validation): support hide edit button on dropdown #3574

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Sep 25, 2024

close #3478

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Sep 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Sep 25, 2024

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 3 seconds
commit  8e6c701
info  For more information, see full report

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 31.84%. Comparing base (53551b2) to head (8e6c701).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...-data-validation/src/views/list-dropdown/index.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3574      +/-   ##
==========================================
- Coverage   31.84%   31.84%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115181   115193      +12     
  Branches    25370    25373       +3     
==========================================
+ Hits        36679    36680       +1     
- Misses      78502    78513      +11     
Flag Coverage Δ
31.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit f2224c3 into dev Sep 25, 2024
9 checks passed
@weird94 weird94 deleted the feat/support-hide-edit-on-dropdown branch September 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Control the edit button of the drop-down box
2 participants