Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): fix insert row col range type #3602

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Sep 27, 2024

close https://github.com/dream-num/univer-pro/issues/2288

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wzhudev wzhudev requested a review from VicKun4937 as a code owner September 27, 2024 04:02
Copy link

github-actions bot commented Sep 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev changed the title fix: fix insert row col range type fix(sheets): fix insert row col range type Sep 27, 2024
Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 9 seconds
commit  59430b0
info  For more information, see full report

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.83%. Comparing base (bb4f035) to head (59430b0).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3602      +/-   ##
==========================================
- Coverage   31.84%   31.83%   -0.01%     
==========================================
  Files        2194     2194              
  Lines      115311   115288      -23     
  Branches    25401    25398       -3     
==========================================
- Hits        36719    36705      -14     
+ Misses      78592    78583       -9     
Flag Coverage Δ
31.83% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Sep 27, 2024
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Sep 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 27, 2024
@wzhudev wzhudev merged commit 8262f7f into dev Sep 27, 2024
10 checks passed
@wzhudev wzhudev deleted the fix/fix-insert-col-row-selections branch September 27, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants