Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto-fill): merge-cell bugs in auto-fill #3606

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Sep 27, 2024

close https://github.com/dream-num/univer-pro/issues/2575
close https://github.com/dream-num/univer-pro/issues/2574

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@yuhongz yuhongz requested a review from ybzky September 27, 2024 09:32
Copy link

Playwright test results

passed  8 passed

Details

stats  8 tests across 3 suites
duration  2 minutes, 10 seconds
commit  11506dc
info  For more information, see full report

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.87%. Comparing base (1113984) to head (11506dc).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
.../sheets-ui/src/controllers/auto-fill.controller.ts 81.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3606   +/-   ##
=======================================
  Coverage   31.87%   31.87%           
=======================================
  Files        2193     2193           
  Lines      115294   115295    +1     
  Branches    25402    25403    +1     
=======================================
+ Hits        36745    36746    +1     
  Misses      78549    78549           
Flag Coverage Δ
31.87% <81.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge scope:data validation labels Sep 27, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Sep 27, 2024
@yuhongz yuhongz merged commit bf21d58 into dev Sep 28, 2024
15 checks passed
@yuhongz yuhongz deleted the yuhongz/fix-autofill-merge-yuhongz branch September 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants