Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapshot area #3715

Merged
merged 4 commits into from
Oct 12, 2024
Merged

fix: snapshot area #3715

merged 4 commits into from
Oct 12, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@lumixraku lumixraku force-pushed the fix/snapshot-area branch 2 times, most recently from b3a9b5b to ec0e0f1 Compare October 11, 2024 09:25
Copy link

github-actions bot commented Oct 11, 2024

Playwright test results

passed  17 passed

Details

stats  17 tests across 8 suites
duration  4 minutes, 6 seconds
commit  bab041e
info  For more information, see full report

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 31.20%. Comparing base (71d2513) to head (bab041e).
Report is 21 commits behind head on dev.

Files with missing lines Patch % Lines
...es/sheets-ui/src/services/sheets-render.service.ts 25.00% 3 Missing ⚠️
packages/engine-render/src/canvas.ts 0.00% 2 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3715      +/-   ##
==========================================
- Coverage   31.24%   31.20%   -0.05%     
==========================================
  Files        2260     2263       +3     
  Lines      117133   117500     +367     
  Branches    25762    25881     +119     
==========================================
+ Hits        36603    36662      +59     
- Misses      80530    80838     +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku force-pushed the fix/snapshot-area branch 3 times, most recently from 241965d to 6d877f4 Compare October 12, 2024 09:12
@lumixraku lumixraku force-pushed the fix/snapshot-area branch 2 times, most recently from d43040b to e7a03bb Compare October 12, 2024 10:42
chore(snapshots): update snapshots
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumixraku lumixraku merged commit 5957a04 into dev Oct 12, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/snapshot-area branch October 12, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants