Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-ui): set focus editing mode when dbclick & error resize when change sub sheet #3725

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 12, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from Jocs as a code owner October 12, 2024 04:01
Copy link

github-actions bot commented Oct 12, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Oct 12, 2024

Playwright test results

passed  16 passed

Details

stats  16 tests across 8 suites
duration  3 minutes, 59 seconds
commit  564abad
info  For more information, see full report

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 31.25%. Comparing base (0c29785) to head (564abad).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 22 Missing ⚠️
...rc/controllers/editor/editing.render-controller.ts 0.00% 9 Missing ⚠️
...eets-data-validation-ui/src/views/detail/index.tsx 0.00% 6 Missing ⚠️
...es/sheets-ui/src/services/editor-bridge.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3725      +/-   ##
==========================================
- Coverage   31.25%   31.25%   -0.01%     
==========================================
  Files        2263     2263              
  Lines      117466   117477      +11     
  Branches    25873    25878       +5     
==========================================
  Hits        36715    36715              
- Misses      80751    80762      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Oct 12, 2024
@weird94 weird94 merged commit 84ac33f into dev Oct 12, 2024
9 checks passed
@weird94 weird94 deleted the fix/editor-range branch October 12, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants