Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(sheets-drawing-ui): float dom scroll performance optimize #3838

Merged
merged 5 commits into from
Oct 24, 2024
Merged

perf(sheets-drawing-ui): float dom scroll performance optimize #3838

merged 5 commits into from
Oct 24, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 24, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested review from jikkai and Jocs as code owners October 24, 2024 03:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit b4b8810 into dev Oct 24, 2024
8 of 9 checks passed
@weird94 weird94 deleted the feat/float-dom-scroll branch October 24, 2024 03:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 59 seconds
commit  b72d9c5
info  For more information, see full report

Failed tests

chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weird94 @Gggpound