Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-hyper-link-ui): add-hyper-link support server computing #3867

Closed
wants to merge 1 commit into from

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Oct 28, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 37 seconds
commit  b68789b
info  For more information, see full report

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.96%. Comparing base (e7b2f78) to head (b68789b).

Files with missing lines Patch % Lines
...ui/src/commands/commands/add-hyper-link.command.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3867   +/-   ##
=======================================
  Coverage   31.96%   31.96%           
=======================================
  Files        2353     2353           
  Lines      121385   121385           
  Branches    26859    26861    +2     
=======================================
  Hits        38805    38805           
  Misses      82580    82580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Oct 28, 2024

I am closing this PR since it has been implemented in #3730.

@wzhudev wzhudev closed this Oct 28, 2024
@jikkai jikkai deleted the fix/add-hyper-link branch October 29, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants