Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): network plugin support overrides #3870

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 28, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Oct 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 28, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 37 seconds
commit  18e560b
info  For more information, see full report

@wzhudev wzhudev merged commit cbabe12 into dev Oct 28, 2024
9 checks passed
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.96%. Comparing base (888c15c) to head (18e560b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/network/src/plugin.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3870      +/-   ##
==========================================
- Coverage   31.96%   31.96%   -0.01%     
==========================================
  Files        2353     2353              
  Lines      121388   121389       +1     
  Branches    26859    26860       +1     
==========================================
  Hits        38805    38805              
- Misses      82583    82584       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev deleted the wzhudev/network-override branch October 28, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants