Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs-ui): doc custom-range & hyperlink #3928

Merged
merged 76 commits into from
Nov 2, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 1, 2024

Breaking changes

  1. Split tags \x1e & \x1f will be removed from body.datastream, this was a stack design, caused too much problems on docs.
  2. No breaking changes on facade api and current command.
  3. Old documents can work as before.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 1, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 1, 2024

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 38 seconds
commit  001cb9d
info  For more information, see full report

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 20.27397% with 291 lines in your changes missing coverage. Please review.

Project coverage is 32.35%. Comparing base (602f44a) to head (001cb9d).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...e/src/docs/data-model/text-x/apply-utils/common.ts 25.00% 69 Missing ⚠️
...docs/data-model/text-x/build-utils/text-x-utils.ts 0.00% 49 Missing ⚠️
...docs/data-model/text-x/apply-utils/update-apply.ts 48.93% 24 Missing ⚠️
...ets-hyper-link-ui/src/views/CellLinkEdit/index.tsx 0.00% 16 Missing ⚠️
...docs/data-model/text-x/build-utils/custom-range.ts 0.00% 14 Missing ⚠️
.../docs-ui/src/services/doc-popup-manager.service.ts 0.00% 12 Missing ⚠️
...s-ui/src/commands/commands/core-editing.command.ts 0.00% 9 Missing ⚠️
...r-link-ui/src/services/hyper-link-popup.service.ts 0.00% 8 Missing ⚠️
...docs-ui/src/commands/commands/ime-input.command.ts 0.00% 8 Missing ⚠️
...kages/sheets-hyper-link-ui/src/controllers/menu.ts 0.00% 8 Missing ⚠️
... and 39 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3928      +/-   ##
==========================================
+ Coverage   32.34%   32.35%   +0.01%     
==========================================
  Files        2457     2458       +1     
  Lines      125886   125838      -48     
  Branches    28109    28109              
==========================================
+ Hits        40717    40719       +2     
+ Misses      85169    85119      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oumomomo oumomomo added the qa:untested This PR is ready to be tested label Nov 2, 2024
@weird94 weird94 removed the qa:untested This PR is ready to be tested label Nov 2, 2024
@weird94 weird94 merged commit b18aba7 into dev Nov 2, 2024
9 checks passed
@weird94 weird94 deleted the refactor/doc-link-1 branch November 2, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants