Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-drawing-ui): sheet-drawing memory leak #4067

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Nov 14, 2024

close https://github.com/dream-num/univer-pro/issues/3296

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 14, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 14, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 14, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 14, 2024
@wzhudev
Copy link
Member

wzhudev commented Nov 14, 2024

Marking this as verified because it does not contain logical changes.

Copy link

github-actions bot commented Nov 14, 2024

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  54a896a
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (7550f1c) to head (5b81798).

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 5 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4067   +/-   ##
=======================================
  Coverage   32.94%   32.94%           
=======================================
  Files        2497     2497           
  Lines      126926   126925    -1     
  Branches    28421    28420    -1     
=======================================
  Hits        41821    41821           
+ Misses      85105    85104    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weird94 weird94 merged commit 4e64ebb into dev Nov 14, 2024
8 of 9 checks passed
@weird94 weird94 deleted the fix/drawing-mem-leak branch November 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants