Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ref selection change by arrow key #4135

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Nov 23, 2024

close https://github.com/dream-num/univer-pro/issues/3468

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  988a900
info  For more information, see full report

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 33.74%. Comparing base (a5041d2) to head (988a900).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4135   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files        2457     2457           
  Lines      127861   127857    -4     
  Branches    28631    28632    +1     
=======================================
  Hits        43141    43141           
+ Misses      84720    84716    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku self-assigned this Nov 23, 2024
@lumixraku lumixraku marked this pull request as ready for review November 23, 2024 09:56
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 23, 2024
@zhaolixin7
Copy link

@lumixraku
路径:1、单元格输入=c3+,2、使用方向选择选区
表现:使用方向不能切换单元格,只能选择C3相邻选区
2024_11_25 15_01_08 video.webm

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Nov 25, 2024
@dream-num dream-num deleted a comment from univer-bot bot Nov 25, 2024
@lumixraku lumixraku added qa:untested This PR is ready to be tested and removed qa:rejected labels Nov 26, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 26, 2024
@lumixraku lumixraku merged commit 444c065 into dev Nov 26, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/ref-selection-keyboard branch November 26, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants