Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): support repeat table header #4139

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Nov 23, 2024

close https://github.com/dream-num/univer-pro/issues/3270

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 23, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 49 seconds
commit  1800b63
info  For more information, see full report

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 160 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (81cf367) to head (1800b63).
Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...e-render/src/components/docs/layout/block/table.ts 0.00% 130 Missing ⚠️
...onents/docs/layout/block/paragraph/linebreaking.ts 0.00% 9 Missing ⚠️
...s-ui/src/controllers/doc-auto-format.controller.ts 0.00% 8 Missing ⚠️
...c/commands/commands/table/doc-table-tab.command.ts 0.00% 6 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 3 Missing ⚠️
packages/docs-ui/src/basics/table.ts 0.00% 2 Missing ⚠️
...es/docs-ui/src/services/doc-auto-format.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4139      +/-   ##
==========================================
- Coverage   33.77%   33.77%   -0.01%     
==========================================
  Files        2487     2487              
  Lines      127668   127689      +21     
  Branches    28601    28609       +8     
==========================================
  Hits        43121    43121              
- Misses      84547    84568      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs force-pushed the feat/dup-table-header branch from 09313b4 to 7a9deb0 Compare November 25, 2024 06:51
@Jocs Jocs marked this pull request as ready for review November 25, 2024 13:17
@Jocs Jocs force-pushed the feat/dup-table-header branch 2 times, most recently from db7352d to 2955b90 Compare November 26, 2024 06:37
@Jocs Jocs added the qa:untested This PR is ready to be tested label Nov 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 27, 2024
@Jocs Jocs force-pushed the feat/dup-table-header branch from 2955b90 to be13a2f Compare November 27, 2024 11:41
@Jocs Jocs requested a review from jikkai as a code owner November 27, 2024 11:56
@Jocs Jocs force-pushed the feat/dup-table-header branch from 5dc0db1 to 9ea7947 Compare November 28, 2024 07:46
@Jocs Jocs force-pushed the feat/dup-table-header branch from 5a9e1cb to df4dc9a Compare November 29, 2024 07:11
@Jocs Jocs force-pushed the feat/dup-table-header branch from df4dc9a to 1800b63 Compare November 29, 2024 07:25
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 29, 2024
@univer-bot univer-bot bot removed the qa:rejected label Nov 29, 2024
@Jocs Jocs merged commit c26f9b0 into dev Nov 29, 2024
9 checks passed
@Jocs Jocs deleted the feat/dup-table-header branch November 29, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants