Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sheets-ui)!: remove duplicate command export #4175

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Nov 28, 2024

AddWorksheetMergeAllCommand has multiple implementations

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@hexf00 hexf00 changed the title chore(sheets-ui): remove duplicate command export refactor(sheets-ui)!: remove duplicate command export Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 49 seconds
commit  839ff73
info  For more information, see full report

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.77%. Comparing base (01ecc28) to head (839ff73).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4175   +/-   ##
=======================================
  Coverage   33.77%   33.77%           
=======================================
  Files        2456     2456           
  Lines      127710   127710           
  Branches    28603    28603           
=======================================
  Hits        43129    43129           
  Misses      84581    84581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexf00 hexf00 merged commit 1f08f24 into dev Nov 29, 2024
11 checks passed
@hexf00 hexf00 deleted the refactor/remove-merge-command branch November 29, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants