Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-filter-ui): fix the react compatibility issue with sheets filter #4189

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Nov 30, 2024

close #4188

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Nov 30, 2024
Copy link

github-actions bot commented Nov 30, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 30, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  8f383dc
info  For more information, see full report

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (9a085c3) to head (8f383dc).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...views/components/SheetsFilterByConditionsPanel.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4189   +/-   ##
=======================================
  Coverage   33.68%   33.68%           
=======================================
  Files        2490     2490           
  Lines      128020   128020           
  Branches    28690    28692    +2     
=======================================
  Hits        43128    43128           
  Misses      84892    84892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Nov 30, 2024
@jikkai jikkai merged commit 61e8ebf into dev Nov 30, 2024
9 checks passed
@jikkai jikkai deleted the fix/filter-react-16 branch November 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crash when I switch filter condition items
1 participant