refactor: getGitHubUser() test and logic improvements (denoland#577)

TSIA

plugins/kv_oauth.ts

@@ -14,6 +14,7 @@ import {
   type User,
 } from "@/utils/db.ts";
 import { isStripeEnabled, stripe } from "@/utils/stripe.ts";
+import { createHttpError } from "std/http/http_errors.ts";
 
 const oauth2Client = createGitHubOAuth2Client();
 
@@ -38,14 +39,14 @@ interface GitHubUser {
  * ```
  */
 export async function getGitHubUser(accessToken: string) {
-  const response = await fetch("https://api.github.com/user", {
+  const resp = await fetch("https://api.github.com/user", {
     headers: { authorization: `Bearer ${accessToken}` },
   });
-  if (!response.ok) {
-    const { message } = await response.json();
-    throw new Error(message);
+  if (!resp.ok) {
+    const { message } = await resp.json();
+    throw createHttpError(resp.status, message);
   }
-  return await response.json() as Promise<GitHubUser>;
+  return await resp.json() as Promise<GitHubUser>;
 }
 
 /**

plugins/kv_oauth_test.ts

@@ -1,11 +1,38 @@
 // Copyright 2023 the Deno authors. All rights reserved. MIT license.
 import { assertRejects } from "std/assert/assert_rejects.ts";
 import { getGitHubUser } from "./kv_oauth.ts";
+import {
+  assertSpyCall,
+  assertSpyCalls,
+  returnsNext,
+  stub,
+} from "std/testing/mock.ts";
+import { Status } from "$fresh/server.ts";
+import { errors } from "std/http/http_errors.ts";
+import { assertEquals } from "std/assert/assert_equals.ts";
 
 Deno.test("[plugins] getGitHubUser()", async () => {
+  const message = crypto.randomUUID();
+  const resp1Body = { message };
+  const resp1 = Promise.resolve(
+    Response.json(resp1Body, { status: Status.BadRequest }),
+  );
+  const resp2Body = { login: crypto.randomUUID(), email: crypto.randomUUID() };
+  const resp2 = Promise.resolve(Response.json(resp2Body));
+  const fetchStub = stub(globalThis, "fetch", returnsNext([resp1, resp2]));
+
+  const accessToken1 = crypto.randomUUID();
+  const accessToken2 = crypto.randomUUID();
   await assertRejects(
-    async () => await getGitHubUser("access token"),
-    Error,
-    "Bad credentials",
+    async () => await getGitHubUser(accessToken1),
+    errors.BadRequest,
+    message,
   );
+  assertEquals(await getGitHubUser(accessToken2), resp2Body);
+
+  fetchStub.restore();
+
+  assertSpyCall(fetchStub, 0, { returned: resp1 });
+  assertSpyCall(fetchStub, 1, { returned: resp2 });
+  assertSpyCalls(fetchStub, 2);
 });